tbls: remove legacy Kryptology-based code #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor usages of the library accordingly.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
+ Coverage 53.59% 53.64% +0.04%
==========================================
Files 174 172 -2
Lines 22697 22411 -286
==========================================
- Hits 12165 12022 -143
+ Misses 9015 8911 -104
+ Partials 1517 1478 -39
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
corverroos
approved these changes
Apr 12, 2023
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old
tblspackage content, and replaces it withtbls/v2content.As a consequence, the
tbls/v2package doesn't exist anymore.All imports have been refactored to accomodate this change.
Kryptology
tbls.Implementationwill be removed on a follow-up PR.category: refactor
ticket: #2055